- Output red error if config commands fail to save config file

- Updated save-related error message text

CHANGELOG.md

@@ -8,7 +8,8 @@ All notable changes to **CreatureChat** are documented in this file. The format
 
 ### Changed
 - Simplified saving of chat data (no more renaming files)
-- Send message to all ops when saving chat data errors (first auto-save happens at 1 minute after launching)
+- If chat data fails to save, send message to all ops (first auto-save happens at 1 minute after launching)
+- If /creaturechat commands fail to save, send message to all ops (fail loudly) and display RED error message
 
 ## [1.0.2] - 2024-05-07
 

src/main/java/com/owlmaddie/chat/ChatDataManager.java

@@ -485,7 +485,7 @@ public class ChatDataManager {
         try (Writer writer = new OutputStreamWriter(new FileOutputStream(saveFile), StandardCharsets.UTF_8)) {
             GSON.toJson(this.entityChatDataMap, writer);
         } catch (Exception e) {
-            String errorMessage = "Error saving chat data to file system. No chat history will be saved. Check file permissions. " + e.getMessage();
+            String errorMessage = "Error saving `chatdata.json`. No CreatureChat chat history was saved! " + e.getMessage();
             LOGGER.error(errorMessage, e);
             ServerPackets.sendMessageToAllOps(server, errorMessage);
         }

src/main/java/com/owlmaddie/commands/ConfigurationHandler.java

@@ -2,8 +2,11 @@ package com.owlmaddie.commands;
 
 import com.google.gson.Gson;
 import com.google.gson.GsonBuilder;
+import com.owlmaddie.network.ServerPackets;
 import net.minecraft.server.MinecraftServer;
 import net.minecraft.util.WorldSavePath;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.io.Reader;
@@ -19,6 +22,7 @@ import java.nio.file.Paths;
  */
 
 public class ConfigurationHandler {
+    public static final Logger LOGGER = LoggerFactory.getLogger("creaturechat");
     private static final Gson gson = new GsonBuilder().setPrettyPrinting().create();
     private final Path serverConfigPath;
     private final Path defaultConfigPath;
@@ -36,12 +40,16 @@ public class ConfigurationHandler {
         return config != null ? config : new Config(); // Return new config if both are null
     }
 
-    public void saveConfig(Config config, boolean useServerConfig) {
+    public boolean saveConfig(Config config, boolean useServerConfig) {
         Path path = useServerConfig ? serverConfigPath : defaultConfigPath;
         try (Writer writer = Files.newBufferedWriter(path)) {
             gson.toJson(config, writer);
+            return true;
         } catch (IOException e) {
-            e.printStackTrace();
+            String errorMessage = "Error saving `creaturechat.json`. CreatureChat config was not saved. " + e.getMessage();
+            LOGGER.error(errorMessage, e);
+            ServerPackets.sendMessageToAllOps(ServerPackets.serverInstance, errorMessage);
+            return false;
         }
     }
 

src/main/java/com/owlmaddie/commands/CreatureChatCommands.java

@@ -62,9 +62,15 @@ public class CreatureChatCommands {
                 config.setModel(value);
                 break;
         }
-        configHandler.saveConfig(config, useServerConfig);
 
-        Text feedbackMessage = Text.literal(settingDescription + " Set Successfully!").formatted(Formatting.GREEN);;
+        Text feedbackMessage;
+        if (configHandler.saveConfig(config, useServerConfig)) {
+            // succeeded
+            feedbackMessage = Text.literal(settingDescription + " Set Successfully!").formatted(Formatting.GREEN);
+        } else {
+            // failed
+            feedbackMessage = Text.literal(settingDescription + " Set Failed!").formatted(Formatting.RED);
+        }
         source.sendFeedback(() -> feedbackMessage, false);
         LOGGER.info("Command executed: " + feedbackMessage.getString());
         return 1;