Improved error handling to prevent broken "..." pending chat status. (HTTP and…

Improved error handling to prevent broken "..." pending chat status. (HTTP and message processing is more protected). Removed randomized error messages from chat history (so it doesn't break the chat history when an error is shown)

CHANGELOG.md

@@ -11,11 +11,13 @@ All notable changes to **CreatureChat** are documented in this file. The format
 
 ### Changed
 - Broadcasting and receiving chat messages now ignores if the UUID is valid (to keep data synced)
+- Improved error handling to prevent broken "..." pending chat status. (HTTP and message processing is more protected)
 
 ### Fixed
 - Bees no longer forget their chat data when entering/leaving hives (writeNbt & readNbt modified)
 - Vexes no longer take damage when chat data exists
 - Wandering Trader no longer despawns if it has chat data
+- Removed randomized error messages from chat history (so it doesn't break the chat history when an error is shown)
 
 ## [1.3.0] - 2025-01-14
 

src/main/java/com/owlmaddie/chat/ChatGPTRequest.java

@@ -196,6 +196,7 @@ public class ChatGPTRequest {
                         lastErrorMessage = cleanError;
                     } catch (Exception e) {
                         LOGGER.error("Failed to read error response", e);
+                        lastErrorMessage = "Failed to read error response: " + e.getMessage();
                     }
                     return null;
                 } else {
@@ -214,12 +215,16 @@ public class ChatGPTRequest {
                     if (chatGPTResponse != null && chatGPTResponse.choices != null && !chatGPTResponse.choices.isEmpty()) {
                         String content = chatGPTResponse.choices.get(0).message.content;
                         return content;
+                    } else {
+                        lastErrorMessage = "Failed to parse response from LLM";
+                        return null;
                     }
                 }
-            } catch (IOException e) {
-                LOGGER.error("Failed to fetch message from ChatGPT", e);
+            } catch (Exception e) {
+                LOGGER.error("Failed to request message from LLM", e);
+                lastErrorMessage = "Failed to request message from LLM: " + e.getMessage();
+                return null;
             }
-            return null; // If there was an error or no response, return null
         });
     }
 }

src/main/java/com/owlmaddie/chat/EntityChatData.java

@@ -273,6 +273,7 @@ public class EntityChatData {
 
         // fetch HTTP response from ChatGPT
         ChatGPTRequest.fetchMessageFromChatGPT(config, promptText, contextData, previousMessages, false).thenAccept(output_message -> {
+            try {
                 if (output_message != null) {
                     // Character Sheet: Remove system-character message from previous messages
                     previousMessages.clear();
@@ -283,24 +284,30 @@ public class EntityChatData {
                     this.addMessage(shortGreeting, ChatDataManager.ChatSender.ASSISTANT, player, systemPrompt);
 
                 } else {
+                    // No valid LLM response
+                    throw new RuntimeException(ChatGPTRequest.lastErrorMessage);
+                }
+
+            } catch (Exception e) {
+                // Log the exception for debugging
+                LOGGER.error("Error processing LLM response", e);
+
                 // Error / No Chat Message (Failure)
                 String randomErrorMessage = Randomizer.getRandomMessage(Randomizer.RandomType.ERROR);
                 this.addMessage(randomErrorMessage, ChatDataManager.ChatSender.ASSISTANT, player, systemPrompt);
 
-                // Determine error message to display
-                String errorMessage = "Help is available at discord.creaturechat.com";
-                if (!ChatGPTRequest.lastErrorMessage.isEmpty()) {
-                    errorMessage = "Error: " + truncateString(ChatGPTRequest.lastErrorMessage, 55) + "\n" + errorMessage;
+                // Remove the error message from history to prevent it from affecting future ChatGPT requests
+                if (!previousMessages.isEmpty()) {
+                    previousMessages.remove(previousMessages.size() - 1);
                 }
 
                 // Send clickable error message
-                ServerPackets.SendClickableError(player,
-                        errorMessage, "http://discord.creaturechat.com");
-
-                // Clear history (if no character sheet was generated)
-                if (characterSheet.isEmpty()) {
-                    previousMessages.clear();
+                String errorMessage = "Error: ";
+                if (e.getMessage() != null && !e.getMessage().isEmpty()) {
+                    errorMessage += truncateString(e.getMessage(), 55) + "\n";
                 }
+                errorMessage += "Help is available at discord.creaturechat.com";
+                ServerPackets.SendClickableError(player, errorMessage, "http://discord.creaturechat.com");
             }
         });
     }
@@ -336,10 +343,11 @@ public class EntityChatData {
 
         // fetch HTTP response from ChatGPT
         ChatGPTRequest.fetchMessageFromChatGPT(config, promptText, contextData, previousMessages, false).thenAccept(output_message -> {
+            try {
                 if (output_message != null) {
                     // Chat Message: Parse message for behaviors
                     ParsedMessage result = MessageParser.parseMessage(output_message.replace("\n", " "));
-                MobEntity entity = (MobEntity)ServerEntityFinder.getEntityByUUID(player.getServerWorld(), UUID.fromString(entityId));
+                    MobEntity entity = (MobEntity) ServerEntityFinder.getEntityByUUID(player.getServerWorld(), UUID.fromString(entityId));
 
                     // Determine entity's default speed
                     // Some Entities (i.e. Axolotl) set this incorrectly... so adjusting in the SpeedControls class
@@ -461,8 +469,8 @@ public class EntityChatData {
                                         // Loop to spawn XP orbs
                                         for (int j = 1; j <= 11; j++) {
                                             float xpFraction = (j == 11) ? 0.2F : 0.08F;
-                                        int xpAmount = MathHelper.floor((float)baseXP * xpFraction);
-                                        ExperienceOrbEntity.spawn((ServerWorld)entity.getWorld(), entity.getPos(), xpAmount);
+                                            int xpAmount = MathHelper.floor((float) baseXP * xpFraction);
+                                            ExperienceOrbEntity.spawn((ServerWorld) entity.getWorld(), entity.getPos(), xpAmount);
                                         }
                                     }
 
@@ -548,24 +556,29 @@ public class EntityChatData {
                             new ChatMessage(result.getOriginalMessage(), ChatDataManager.ChatSender.ASSISTANT, player.getDisplayName().getString()));
 
                 } else {
+                    // No valid LLM response
+                    throw new RuntimeException(ChatGPTRequest.lastErrorMessage);
+                }
+
+            } catch (Exception e) {
+                // Log the exception for debugging
+                LOGGER.error("Error processing LLM response", e);
+
                 // Error / No Chat Message (Failure)
                 String randomErrorMessage = Randomizer.getRandomMessage(Randomizer.RandomType.ERROR);
                 this.addMessage(randomErrorMessage, ChatDataManager.ChatSender.ASSISTANT, player, systemPrompt);
 
-                // Determine error message to display
-                String errorMessage = "Help is available at discord.creaturechat.com";
-                if (!ChatGPTRequest.lastErrorMessage.isEmpty()) {
-                    errorMessage = "Error: " + truncateString(ChatGPTRequest.lastErrorMessage, 55) + "\n" + errorMessage;
+                // Remove the error message from history to prevent it from affecting future ChatGPT requests
+                if (!previousMessages.isEmpty()) {
+                    previousMessages.remove(previousMessages.size() - 1);
                 }
-
                 // Send clickable error message
-                ServerPackets.SendClickableError(player,
-                        errorMessage, "http://discord.creaturechat.com");
-
-                // Clear history (if no character sheet was generated)
-                if (characterSheet.isEmpty()) {
-                    previousMessages.clear();
+                String errorMessage = "Error: ";
+                if (e.getMessage() != null && !e.getMessage().isEmpty()) {
+                    errorMessage += truncateString(e.getMessage(), 55) + "\n";
                 }
+                errorMessage += "Help is available at discord.creaturechat.com";
+                ServerPackets.SendClickableError(player, errorMessage, "http://discord.creaturechat.com");
             }
         });
     }