Fixing crash when displaying message on LeadPlayerGoal, to run the…

Fixing crash when displaying message on LeadPlayerGoal, to run the generateMessage in a scheduler (after 1 tick), and not in the Goal's tick method.

src/main/java/com/owlmaddie/chat/ChatDataSaverScheduler.java

@@ -11,8 +11,10 @@ import java.util.concurrent.TimeUnit;
  */
 public class ChatDataSaverScheduler {
     private final ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1);
+    private MinecraftServer server = null;
 
     public void startAutoSaveTask(MinecraftServer server, long interval, TimeUnit timeUnit) {
+        this.server = server;
         ChatDataAutoSaver saverTask = new ChatDataAutoSaver(server);
         scheduler.scheduleAtFixedRate(saverTask, 1, interval, timeUnit);
     }
@@ -20,4 +22,9 @@ public class ChatDataSaverScheduler {
     public void stopAutoSaveTask() {
         scheduler.shutdown();
     }
+
+    // Schedule a task to run after 1 tick (basically immediately)
+    public void scheduleTask(Runnable task) {
+        scheduler.schedule(() -> server.execute(task), 50, TimeUnit.MILLISECONDS);
+    }
 }

src/main/java/com/owlmaddie/goals/LeadPlayerGoal.java

@@ -61,14 +61,16 @@ public class LeadPlayerGoal extends PlayerBaseGoal {
             foundWaypoint = true;
             LOGGER.info("destination reached");
 
-            // Prepare a message about the interaction
-            String arrivedMessage = "<You have arrived at your destination>";
-
-            ChatDataManager chatDataManager = ChatDataManager.getServerInstance();
-            ChatDataManager.EntityChatData chatData = chatDataManager.getOrCreateChatData(this.entity.getUuidAsString());
-            if (!chatData.characterSheet.isEmpty() && chatData.auto_generated < chatDataManager.MAX_AUTOGENERATE_RESPONSES) {
-                ServerPackets.generate_chat("N/A", chatData, (ServerPlayerEntity) this.targetEntity, this.entity, arrivedMessage, true);
-            }
+            ServerPackets.scheduler.scheduleTask(() -> {
+                // Prepare a message about the interaction
+                String arrivedMessage = "<You have arrived at your destination>";
+
+                ChatDataManager chatDataManager = ChatDataManager.getServerInstance();
+                ChatDataManager.EntityChatData chatData = chatDataManager.getOrCreateChatData(this.entity.getUuidAsString());
+                if (!chatData.characterSheet.isEmpty() && chatData.auto_generated < chatDataManager.MAX_AUTOGENERATE_RESPONSES) {
+                    ServerPackets.generate_chat("N/A", chatData, (ServerPlayerEntity) this.targetEntity, this.entity, arrivedMessage, true);
+                }
+            });
 
             // Stop navigation
             this.entity.getNavigation().stop();

src/main/java/com/owlmaddie/network/ServerPackets.java

@@ -42,7 +42,7 @@ import java.util.concurrent.TimeUnit;
 public class ServerPackets {
     public static final Logger LOGGER = LoggerFactory.getLogger("creaturechat");
     public static MinecraftServer serverInstance;
-    private static ChatDataSaverScheduler scheduler = null;
+    public static ChatDataSaverScheduler scheduler = null;
     public static final Identifier PACKET_C2S_GREETING = new Identifier("creaturechat", "packet_c2s_greeting");
     public static final Identifier PACKET_C2S_READ_NEXT = new Identifier("creaturechat", "packet_c2s_read_next");
     public static final Identifier PACKET_C2S_SET_STATUS = new Identifier("creaturechat", "packet_c2s_set_status");
@@ -295,10 +295,8 @@ public class ServerPackets {
 
     public static void generate_chat(String userLanguage, ChatDataManager.EntityChatData chatData, ServerPlayerEntity player, MobEntity entity, String message, boolean is_auto_message) {
         // Set talk to player goal (prevent entity from walking off)
-        if (!is_auto_message) {
-            TalkPlayerGoal talkGoal = new TalkPlayerGoal(player, entity, 3.5F);
-            EntityBehaviorManager.addGoal(entity, talkGoal, GoalPriority.TALK_PLAYER);
-        }
+        TalkPlayerGoal talkGoal = new TalkPlayerGoal(player, entity, 3.5F);
+        EntityBehaviorManager.addGoal(entity, talkGoal, GoalPriority.TALK_PLAYER);
 
         // Add new message
         LOGGER.info("Player message received: " + message + " | Entity: " + entity.getType().toString());